linalg.pitch_yaw_roll_from_quaternion returns non-zero pitch from identity quaternion

[hdooley]

Context

main :: proc() {
    quat : linalg.Quaternionf32;

    quat = quaternion(1, 0, 0, 0);

    pitch, yaw, roll := linalg.pitch_yaw_roll_from_quaternion(quat);
    quat2            := linalg.quaternion_from_pitch_yaw_roll(pitch, yaw, roll);

    fmt.printf("quat = %v\nquat2 = %v\n", quat, quat2);
}

output:

quat = 1.000+0.000i+0.000j+0.000k
quat2 = 0.851+0.526i+0.000j+0.000k

• Operating System: windows odin.exe version dev-2021-10:3337d386

Expected Behavior

pitch, yaw, and roll should all equal 0 when getting euler angles from the identity quaternion.

Current Behavior

pitch is non-zero, resulting in a non-identity quaternion

Steps to Reproduce

build and run the above program observe the output of quat and quat2

[github-actions[bot]]

Hello!

I am marking this issue as stale as it has not received any engagement from the community or maintainers 120 days. That does not imply that the issue has no merit! If you feel strongly about this issue

• open a PR referencing and resolving the issue;
• leave a comment on it and discuss ideas how you could contribute towards resolving it;
• leave a comment and describe in detail why this issue is critical for your use case;
• open a new issue with updated details and a plan on resolving the issue.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone..