odilia-app
Maintanance fixes
Review with rigor, handle with care, scrutinize like it's 1999!
See individual commits for details.
- Rename 'accessible' --> 'obj'
- Fix missing feature in atspi crate
- Update dependencies
- Deprecation of "default_features"
- Fix search-and-replace mishap
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.69%. Comparing base (
85d7518) to head (f1696af). Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #184 +/- ##
==========================================
+ Coverage 83.74% 86.69% +2.95%
==========================================
Files 39 39
Lines 3112 3338 +226
==========================================
+ Hits 2606 2894 +288
+ Misses 506 444 -62
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thank you again Luuk for catching these important issues! I really would have never noticed, because I know the history and would have brushed it off.
I'm curious why you chose to upgrade zbus and zvarinat though? Generally, we want to use the oldest compatible version of dependencies. It would be a shame if we caused a version mismatch downstream just by being too aggressive about upstream upgrades.
zbus 4.2.1 has a number of "Critical fixes", especially the one where properties are invalidated after querying(?) seems problematic. Also "Hack to make connection handshake work inside Flatpak. xdg-dbus-proxy" might be of importance for us. zbus 4.2.0 dropped two dependencies.
I chose to also upgrade zvariant to keep the z-crates underlying dependencies in sync.
But if you want to investigate this a bit further, I am fine if you drop this commit and just take the others.