ttv-ublock icon indicating copy to clipboard operation
ttv-ublock copied to clipboard

concat scripts to a single file

Open Scrxtchy opened this issue 3 years ago • 3 comments

Not really much point in adding complexity to the build operation when you can just use a test what browser someone is using and alter the operation based on that condition.

Build script may need testing, I believe my version of zip behaves differently, you could forgo the build version folder entirely if you wanted seeing there's now only single output

Scrxtchy avatar Nov 26 '20 02:11 Scrxtchy

@Scrxtchy is attempting to deploy a commit to a Personal Account owned by @odensc on Vercel.

@odensc first needs to authorize it.

vercel[bot] avatar Nov 26 '20 02:11 vercel[bot]

Is there a better way of checking the browser besides detecting chrome.app?

odensc avatar Nov 28 '20 08:11 odensc

There's a few other ways, but you're really just going to check if any of these functions exist or not. Firefox has a runtime.getBrowserInfo() which returns an Promise if you want to do string compare, but this function doesn't appear to exist within chrome's runtime api.

An old way of checking was to check if the chrome api was undefined on firefox, but this now exists on the platform for porting assistance (the browser standard api uses Promises)

Scrxtchy avatar Nov 28 '20 09:11 Scrxtchy