drive icon indicating copy to clipboard operation
drive copied to clipboard

Ubuntu snap for drive

Open Dedsec1 opened this issue 8 years ago • 7 comments

Hi odeke-em

i wanted to make it easier for people to install drive on different types of Linux distros, so i went ahead an setup an Ubuntu snap for drive, you can install drive by doing the following command. luckily snaps can be deployed on other distros as well such as Redhat, CentOS, Debian etc. currently i have my launchpad account pulling from my fork automatically using git and building an new snap each time i change something. so once you add my snapcraft.yaml file to the main repo for drive, i can change my launchpad settings to grab any changes automatically and push an new snap.

https://github.com/Dedsec1/drive/

https://github.com/Dedsec1/drive/blob/master/snapcraft.yaml

sudo snap install drive --classic

Regards

Dedsec1

Dedsec1 avatar Feb 12 '17 01:02 Dedsec1

@odeke-em is there anything that blocks this PR from merging?

idvoretskyi avatar Feb 07 '18 13:02 idvoretskyi

My apologies for the very late reply @Dedsec1, I have been swamped for the past year and more. Awesome, I'll kindly page some Linux folks to help me review this change @shaggytwodope @m-svo. Also @LyzardKing posted some feedback PTAL.

@idvoretskyi nothing blocking it, I was just away from here for a while :)

odeke-em avatar Jun 20 '19 07:06 odeke-em

@odeke-em The only thing I'd add to the current PR are the following lines:

version: 'master'
version-script: |
    grep "Version =" src/about.go | cut -d'"' -f2
base: core18

First we set the version to a string, then we override it with the actual drive version. Then in the 3rd line the base is updated to the latest ubuntu LTS

Also, the classic option when installing is no longer needed. @odeke-em If there's anything needed to get this completed let me know!

LyzardKing avatar Jun 20 '19 08:06 LyzardKing

@odeke-em sorry, not my area of expertise, so not able to review

omicron-b avatar Jun 20 '19 19:06 omicron-b

@odeke-em There seems to be an outdated version already uploaded to the snap store. Once the snapcraft.yaml file is included in the repo you can ask on the snapcraft forum for the ownership of the snap to be transferred to you. And the snap would build automatically on every upstream commit.

LyzardKing avatar Jun 20 '19 19:06 LyzardKing

the ownership of the snap to be transferred to you

+1.

idvoretskyi avatar Jul 01 '19 19:07 idvoretskyi

@odeke-em What can we do to get this merged? I can open another PR with my changes.. A part from that I can tell that I have it built with my snap changes and it seems to work properly. Although there might be something else that needs testing..

LyzardKing avatar Jul 02 '19 06:07 LyzardKing