oddlama
Removed ProtocolLib + Resource pack load during Paper's configuration
It was a bit of a struggle but I finally have it working. Please let me know if there is something wrong with my code. A lot of these events and methods I've never used before so something might be off/incorrect.
There are some points of discussion I'd like to bring up and ask about:
Permissions
I asked this is Discord but might as well put this in here in case anybody else wants to discuss. The way Paper's configuration phase works is you don't have access to the full player object but rather a PlayerProfile. This means it's a bit trickier to gather what permissions the player has and if they should be able to use vane.core.resource_pack.bypass to bypass resource pack requirements.
An alternative might be to interface directly with popular permission plugins like LuckPerms and of course Vane Permissions, but these optional hooks might need to be updated and people might ask for more permission plugins to be added (which of course might not be an actual issue). I haven't tried any sort of workaround to get permissions without hooking into these plugins, so if you have any ideas let me know.
Custom Message & Translations on Resource Pack Confirmation Screen
We can add a message or let admins customize what message goes on the resource pack confirmation screen. I would look like this:
Though I am unfamiliar with how Vane's language and translation system and also config file system works. Obviously the text above the custom message adhere's the Minecraft's language selection and it would be nice if we could query Vane to send the correct message based on the player's language settings.
Does Vane auto add config settings programmatically and automatically stick them onto existing users configs? Does the same thing work for lang messages? Any insight here would be great. 🙏
Let me know your thoughts and we can go from there, thanks!
Also if we don't need protocollib anymore, can you do a quick find-in-all-files in the codebase to see if there are any mentions left? I think it would be good to update the readme and other stuff that references it.
Also if we don't need protocollib anymore, can you do a quick find-in-all-files in the codebase to see if there are any mentions left? I think it would be good to update the readme and other stuff that references it.
Sure! I'll do that when I get a chance today or tomorrow 👍