cloud-cryptographic-wallet icon indicating copy to clipboard operation
cloud-cryptographic-wallet copied to clipboard

feat(aws-kms-provider): provide endpoint argument

Open moreal opened this issue 3 years ago • 1 comments

This pull request introduces also endpoint argument to use specific endpoint manually.

moreal avatar Jul 25 '22 06:07 moreal

Pull Request Test Coverage Report for Build 2730461664

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.0%

Totals Coverage Status
Change from base Build 2635630682: 0.0%
Covered Lines: 118
Relevant Lines: 131

💛 - Coveralls

coveralls avatar Jul 25 '22 06:07 coveralls

@moreal BTW, aws-kms-provider has been rewrite into @cloud-cryptographic-wallet/web3-provider-adapter and @cloud-cryptographic-wallet/aws-kms-signer. I recommend switching to this libraries if possible.

https://github.com/odanado/cloud-cryptographic-wallet/blob/master/packages/web3-provider-adapter/README.md

odanado avatar Aug 12 '22 18:08 odanado

I'm working on resolving the GitHub Actions error. It will be a while before I can merge the pull requests and publish the library.

odanado avatar Aug 12 '22 18:08 odanado

I ran the e2e test locally and confirmed it succeeded.

$ AWS_PROFILE=root RPC_URL=http://localhost:8501 yarn e2e
 ✓ packages/asn1-parser/src/parse-public-key.spec.ts (2)
 ✓ packages/asn1-parser/src/parse-signature.spec.ts (3)
 ✓ test/e2e/ethers/send-eth.spec.ts (2) 2509ms
 ✓ test/e2e/legacy/ethers-send-eth.spec.ts (1) 2449ms
 ✓ test/e2e/legacy/web3-send-eth.spec.ts (1) 1685ms
 ✓ test/e2e/legacy/web3-sign.spec.ts (1) 902ms
 ✓ test/e2e/web3/send-eth.spec.ts (2) 2132ms

Test Files  7 passed (7)
     Tests  12 passed (12)
      Time  10.82s (in thread 9.69s, 111.65%)

odanado avatar Aug 18 '22 16:08 odanado

@moreal This change was released in [email protected]

odanado avatar Aug 18 '22 16:08 odanado