opam-repo-ci icon indicating copy to clipboard operation
opam-repo-ci copied to clipboard

UI: Reorganize the summary of errors by type of errors to make things easier to read

Open kit-ty-kate opened this issue 2 years ago • 3 comments

Request by @UnixJunkie in https://github.com/ocaml/opam-repository/pull/24327#issuecomment-1705803328

Sadly this one makes things harder to read as the current error detection system isn't clever enough to regroup similar issues: scrn-2023-09-05-16-03-43

kit-ty-kate avatar Sep 05 '23 15:09 kit-ty-kate

How do you think the errors should be grouped? Maybe it could a header per package and then group them by version beneath the header.

benfaerber avatar Sep 06 '23 23:09 benfaerber

I think extending and improving the error detection system

https://github.com/ocurrent/opam-repo-ci/blob/980e10178b06f27d1b4161afd15afe0fab042082/service/main.ml#L28

would group most errors pretty well. Especially something to get either detect errors further or post-process the The compilation of <pkg> failed at "..." type errors would fix most errors i feel like.

Regrouping per package would definitely not be enough, you want to regroup by type of errors as it makes reading the output much easier.

kit-ty-kate avatar Sep 11 '23 17:09 kit-ty-kate

Yes, the important thing is regrouping by type of error. Then you know how many errors there are to repair.

On Tue, Sep 12, 2023 at 2:53 AM Kate @.***> wrote:

I think extending and improving the error detection system

https://github.com/ocurrent/opam-repo-ci/blob/980e10178b06f27d1b4161afd15afe0fab042082/service/main.ml#L28

would group most errors pretty well. Especially something to get either detect errors further or post-process the The compilation of failed at "..." type errors would fix most errors i feel like.

Regrouping per package would definitely not be enough, you want to regroup by type of errors as it makes reading the output much easier.

— Reply to this email directly, view it on GitHub https://github.com/ocurrent/opam-repo-ci/pull/233#issuecomment-1714334748, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFUFAGRHGOYJ7SOTMESWA3XZ5F2BANCNFSM6AAAAAA4L6CFPY . You are receiving this because you were mentioned.Message ID: @.***>

UnixJunkie avatar Sep 12 '23 01:09 UnixJunkie

Since this PR seems stalled, and more substantial design and refactoring work is needed, I'm closing it in favor of https://github.com/ocurrent/opam-repo-ci/issues/312 for know. Please reopen if I'm mistaken and this can still move forward as is.

shonfeder avatar May 22 '24 09:05 shonfeder