ocaml-ci
ocaml-ci copied to clipboard
ocurrent
Test the opam file as well
The content of the opam file is never tested by ocaml-ci. Several users have had the issue in the past where dune build works fine but dune build -p <pkg> does not (e.g. merlin's testsuite)
Does this need to be done on every platform? It doubles the build work - wouldn’t it be better as a next pipeline stage after the other builds have succeeded (for example, just on Ubuntu)?
This will also fail if not all the packages are available on that particular switch. I think we need something more on the lines of the discussion in #297 where an explicit subset of packages can be passed through from the solver to the platform.
This will likely also cause problems for vendored dependencies (that will be removed before the final release to opam-repository).
Is this a big problem? I'd expect any problems here would be picked up at release time by dune-release and would be easily fixed then.
Is this a big problem? I'd expect any problems here would be picked up at release time by dune-release and would be easily fixed then.
If we wanted this functionality to continuously check the "releasability" of packages, then it should be a limited linting step that applies to a single linux distro (Ubuntu) and runs after the other builds have succeeded. Potentially only running on the default branch rather than all git refs.
Closing due to the age of this PR and the various concerns raised. If we move forward with this, it would be along the lines of https://github.com/ocurrent/ocaml-ci/pull/314#issuecomment-785890604 .
