current-bench icon indicating copy to clipboard operation
current-bench copied to clipboard

Investigate current-bench removing statuses of other checks on `master`

Open punchagan opened this issue 2 years ago • 4 comments

Reported here by @kit-ty-kate

punchagan avatar May 03 '23 06:05 punchagan

Looks like this is the offending commit.

punchagan avatar May 05 '23 03:05 punchagan

The logs for the set-status job look like this:

2023-04-25 17:53.03: New job: Set ocaml/opam refs/heads/master
                     e66648f0/ocaml-benchmarks to
                     {"state":"pending","target_url":"https://autumn.ocamllabs.io/ocaml/opam"}
2023-04-25 17:53.03: Waiting for resource in pool github
2023-04-25 17:53.07: Got resource from pool github
2023-04-25 17:53.07: POST https://api.github.com/repos/ocaml/opam/statuses/e66648f07b950e5ba144a477432f437bfd8059ec:
                       {
                         "context": "ocaml-benchmarks",
                         "state": "pending",
                         "target_url": "https://autumn.ocamllabs.io/ocaml/opam"
                       }
2023-04-25 17:53.08: Job succeeded

I've looked at the code, and tried to look at the API docs and it doesn't seem like something like this would "delete" other statuses.

punchagan avatar May 05 '23 05:05 punchagan

The same thing happened for already opened PRs on ocaml/opam

kit-ty-kate avatar May 08 '23 13:05 kit-ty-kate

Okay, thanks for the additional information.

punchagan avatar May 09 '23 04:05 punchagan