current-bench icon indicating copy to clipboard operation
current-bench copied to clipboard

Some benchmarks seem to run multiple times

Open punchagan opened this issue 3 years ago • 1 comments

@art-w reported that:

For example, this benchmark seems to run more than expected https://autumn.ocamllabs.io/Zineb-Ada/bechamel-fact?worker=autumn&image=ocaml%2Fopam%3Adebian-11-ocaml-4.13

I tried to debug/understand this issue further, and here's some debugging information:

  • I looked at the Database and it does seem to have 3 different runs captured in the DB.
         run_at         |                  commit                  |         repo_id         | worker |          docker_image
------------------------+------------------------------------------+-------------------------+--------+---------------------------------
 2022-05-12 13:32:33.7  | 424ae1762b04c61510a9a91505c5d11086ff03de | Zineb-Ada/bechamel-fact | autumn | ocaml/opam:debian-11-ocaml-4.13
 2022-05-16 17:10:20.01 | 424ae1762b04c61510a9a91505c5d11086ff03de | Zineb-Ada/bechamel-fact | autumn | ocaml/opam:debian-11-ocaml-4.13
 2022-05-23 17:10:36.8  | 424ae1762b04c61510a9a91505c5d11086ff03de | Zineb-Ada/bechamel-fact | autumn | ocaml/opam:debian-11-ocaml-4.13

  • The production.conf file doesn't have any configuration for this repository. So, the default worker and docker_image are used for the benchmark runs.
  • The check for preventing duplicate runs looks for benchmarks for the same repo, commit, worker and docker_image. Unless one of these become NULL when running the check, I'm not sure how the check fails. If there's no configuration for a repo, since it should be using the default values for the exists check.
  • I tried to trigger a new build by redeploying the production server, and it didn't seem to add any new benchmark runs.

I'm not sure what else could be causing the bug. @art-w @Zineb-Ada do you have any other ideas or hunches on what could possibly be going on?

punchagan avatar May 25 '22 09:05 punchagan

I found a bunch of similar other instances, like

# select run_at,commit,repo_id,worker,docker_image from benchmarks where commit = '5f9a76290089a5f80b5103879941ebe4a6c35350' and test_index=0;
         run_at         |                  commit                  |        repo_id        | worker |          docker_image           
------------------------+------------------------------------------+-----------------------+--------+---------------------------------
 2022-03-14 12:03:32.21 | 5f9a76290089a5f80b5103879941ebe4a6c35350 | ocaml-ppx/ocamlformat | autumn | ocaml/opam:debian-11-ocaml-4.13
 2022-03-14 17:05:30.48 | 5f9a76290089a5f80b5103879941ebe4a6c35350 | ocaml-ppx/ocamlformat | autumn | ocaml/opam:debian-11-ocaml-4.13
 2022-03-21 17:06:18.77 | 5f9a76290089a5f80b5103879941ebe4a6c35350 | ocaml-ppx/ocamlformat | autumn | ocaml/opam:debian-11-ocaml-4.13

punchagan avatar May 25 '22 13:05 punchagan