:lady_beetle: [BUG] Sending to Group MMS Doesn't Delay

[nelsam]

Describe the bug Sending to a group MMS does not respect my Delayed sending preferences. It seems like either MMS doesn't respect that setting, or group chats don't respect it. Or possibly both? I haven't tried sending an MMS to a single recipient.

To Reproduce Steps to reproduce the behavior:

1. Set Delayed sending to a non-zero value (I've set mine to 10 seconds)
2. Send a message to a group chat

Expected behavior I see the send delay and am able to cancel my message

Actual behavior The message sends immediately

Smartphone (please complete the following information):

• Device: Fairphone 5
• OS: Custom Rom (e/OS)
• App Version: 4.1.0 and 4.1.1

Additional context I originally found the issue on v4.1.0 when I accidentally sent a message to the wrong chat. I went to cancel it and realized that it didn't give me a delayed send.

I double-checked with a new group chat, using both my own number and one other person as recipients, and saw the same behavior.

I then updated to v4.1.1 to confirm that the issue is still present. Sending a message to the test group chat still sends immediately, ignoring my delayed sending setting.

[wiggleforlife]

I don't think this was a bug. I think, for some reason, delayed MMS messages (group messages are always MMS) don't exist in this app... there is no code for it. Looking in to the history, MMS functions were in a different class than SMS functions, and the original author only added the delay to SMS. This survived a consolidation of this class (MessageRepoImpl) and of the two functions. Unless I'm missing something, it took seven years to find this issue! Nice find!

Edit: I just checked QKSMS' issues and someone did find it (https://github.com/moezbhatti/qksms/issues/1496) but nothing was done about it

[gavine99]

i have implemented this feature - please see pr https://github.com/octoshrimpy/quik/pull/430