substrate-ibc
substrate-ibc copied to clipboard
octopus-network
An IBC implementation on Substrate
Hi guys, great work! I'm trying to run the demo (I've uncommented cli and relayer workspace members, but the relayer yields an error message: .... caused by: failed to load...
Some Reader functions are Duplicated. - [ ] Read `ClientStates`: duplicated for 3 times. [Implemented in channel.rs](https://github.com/octopus-network/substrate-ibc/blob/ee60ff6bef9fab48583253cd23b6da326cdac203/src/channel.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L86); [Implemented in client.rs](https://github.com/octopus-network/substrate-ibc/blob/ee60ff6bef9fab48583253cd23b6da326cdac203/src/client.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L43); [Implemented in connection.rs](https://github.com/octopus-network/substrate-ibc/blob/ee60ff6bef9fab48583253cd23b6da326cdac203/src/connection.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L34) - [ ] Read `ConsensusStates`: duplicated 3...
In the file [src/channel.rs](https://github.com/octopus-network/substrate-ibc/blob/9a4c0c36eb407b7066429e0efd60813ff2789d36/src/channel.rs?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L220), there are a few conversions from Vec to Vec, which look redundant. ```rust let mut data: &[u8] = &data; let data = Vec::::decode(&mut data).unwrap(); ``` But...
We should fix this command https://github.com/octopus-network/ibc-demo/blob/84b196c9a170dc63a14a90b544f6d3876f7e641e/cli/src/main.rs#L54 Use data like this https://github.com/informalsystems/ibc-rs/blob/c78b793d99571df4781cec4c2cfcb18ed68098d1/guide/src/commands/queries/client.md to create a real `MsgCreateAnyClient`. Then send the message to a dev node, make sure the data is stored...
Something tedious in engineering may occur when converting data structure between protobuf and substrate’s SCALE. Here's an example, which converting ibc-rs' `ClientState` to substrate's `ClientState`. * Define substrate's `ClientState`: https://github.com/cdot-network/substrate-ibc/commit/aa0e1b60bd56408bba34e52e910a3730f0cdb330#diff-bf7b01306aff35bb8c429e9d0b60028c041e7e93ab3453a60ec009420eebd53cL1-L39...
``` impl Ics18Context for Context { fn query_latest_height(&self) -> Height { let revision_height = host_height::(); Height::new(REVISION_NUMBER, revision_height).expect(&REVISION_NUMBER.to_string()) } fn query_client_full_state(&self, client_id: &ClientId) -> Option { // Forward call to Ics2....
# ics02client - host_consensus_state - pending_host_consensus_state - host_height # need add ics10-grandpa-client to ics02client implement api file