request.js icon indicating copy to clipboard operation
request.js copied to clipboard

Improve tests

Open Uzlopak opened this issue 1 year ago • 1 comments

needs #700

Uzlopak avatar Jun 27 '24 17:06 Uzlopak

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

github-actions[bot] avatar Jun 27 '24 17:06 github-actions[bot]

@gr2m @wolfy1339

ready for review ;)

Uzlopak avatar Jul 08 '24 15:07 Uzlopak

Can you explain what this PR does? How is it improving tests?

wolfy1339 avatar Jul 08 '24 15:07 wolfy1339

It uses tests, which use the native fetch implementation, thus avoiding that our tests are pure mocks and giving use confidence, that native fetch really works with our implementation.I could actually implement it differently and we could test e.g. node-fetch@v2 too.

Uzlopak avatar Jul 08 '24 15:07 Uzlopak

we could test e.g. node-fetch@v2 too

let's not do that 😅

gr2m avatar Jul 10 '24 00:07 gr2m

@gr2m

Done :)

Uzlopak avatar Jul 10 '24 10:07 Uzlopak

:tada: This issue has been resolved in version 9.1.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Jul 13 '24 11:07 github-actions[bot]