Improve tests
needs #700
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀
@gr2m @wolfy1339
ready for review ;)
Can you explain what this PR does? How is it improving tests?
It uses tests, which use the native fetch implementation, thus avoiding that our tests are pure mocks and giving use confidence, that native fetch really works with our implementation.I could actually implement it differently and we could test e.g. node-fetch@v2 too.
we could test e.g. node-fetch@v2 too
let's not do that 😅
@gr2m
Done :)
:tada: This issue has been resolved in version 9.1.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket: