plugin-enterprise-server.js
plugin-enterprise-server.js copied to clipboard
[BUG]: Missing endpoints for management of runner groups on the Repo and Org level
What happened?
I'm upgrading to newer plugin-enterprise-server.js (from 10.6.4 to 15.1.3) and realized that endpoints that I used and are still part of GitHub ES 3.9 are missing:
- https://docs.github.com/en/[email protected]/rest/actions/self-hosted-runner-groups?apiVersion=2022-11-28#list-self-hosted-runner-groups-for-an-organization
- https://docs.github.com/en/[email protected]/rest/actions/self-hosted-runner-groups?apiVersion=2022-11-28#create-a-self-hosted-runner-group-for-an-organization
- https://docs.github.com/en/[email protected]/rest/actions/self-hosted-runner-groups?apiVersion=2022-11-28#get-a-self-hosted-runner-group-for-an-organization
- https://docs.github.com/en/[email protected]/rest/actions/self-hosted-runner-groups?apiVersion=2022-11-28#update-a-self-hosted-runner-group-for-an-organization
- https://docs.github.com/en/[email protected]/rest/actions/self-hosted-runner-groups?apiVersion=2022-11-28#delete-a-self-hosted-runner-group-from-an-organization
- etc. basically all action runner groups endpoints for organization, I didn't use the ones for enterprise.
Before that I used these without issues.
Versions
"@octokit/plugin-enterprise-server": "^15.1.3", "probot": "^13.0.0-beta.2",
NodeJS 20.9.0
Relevant log output
No response
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs
. You & others like you are the reason all of this works! So thank you & happy coding! 🚀
Thanks for taking the time for testing out Probot v13, and reporting this issue.
The routes are auto generated from GitHub's OpenAPI spec, we don't manually add them. However the GitHub docs for the REST API are also generated from the OpenAPI spec.
We don't take in account the API versioning in Octokit anywhere, yet.
It's possible that it is still present in 2022-11-28
but not in the unversioned spec
Hard to say, I checked specs for Server 3.9 and 3.10 and the API is there. I can't unselect the API version and even if I try to remove it from URL it is auto-added by GH web...
Looking at the plugin-enterprise-cloud.js
it has these endpoints there. And both EC and ES use the same spec.
So to me it looks like these are filtered out somehow.