octokit.net icon indicating copy to clipboard operation
octokit.net copied to clipboard

Published 20 hours ago • verified publisher icon octokit

RepoCollaboratorsClient.Add throws exception with 201 status code (Created)

Open marwie opened this issue 3 years ago • 3 comments

Hello, looks like github changed the return code for adding collaborators

STRP:

  1. check "IsCollaborator"
  2. if false call "Add"
  3. observe exception

Using octokit 0.50.0

image

marwie avatar Nov 16 '21 16:11 marwie

@nickfloyd this check is only performed when there is a CollaboratorRequest passed in. This appears to be organisation-owned/enterprise only. Unfortunately I don't have access to test this, do you? RepoCollaboratorsClient.Add methods.

JonruAlveus avatar Jul 14 '22 05:07 JonruAlveus

@JonruAlveus Thanks for the heads up on this. I've added it to the board to put some 👀's on it soon to verify and fix.

nickfloyd avatar Jul 14 '22 16:07 nickfloyd

Hi @marwie, could you confirm if this is still occurring? I can't now reproduce it. Thanks!

JonruAlveus avatar Aug 12 '22 06:08 JonruAlveus