oauth-app.js
oauth-app.js copied to clipboard
refactor(middleware): remove aws-lambda handler
This PR fixes #332. Something to be mentioned:
- I removed the
onUnhandledRequest
option. Callers can still custom unhandled requests: use the express*
router (as covered by the test cases) or check if the response is a404
. - I removed
fromentries
because we’re not supporting Node.js v10/12. - I refactored the tests.
node-middleware.test.ts
andweb-worker-handler.test.ts
are small now because the source files are small.
I am not sure if someone relies on the aws-lambda
middleware. I would like to help (just open an issue).
I tried really hard to bypass the “Hard-coded credentials” only found she is smarter than me.
I tried really hard to bypass the “Hard-coded credentials” only found she is smarter than me.
Those can be safely ignored. They are known false positives since in this case they are not valid access tokens and only used in documentation
Let's split out the changes into a different PR, and focus on removing aws-lamba
in this one
Great suggestion. This PR only removes the lambda handler.