core.js icon indicating copy to clipboard operation
core.js copied to clipboard

Implement types for authentication strategies

Open gr2m opened this issue 3 years ago • 4 comments

Blocked by https://github.com/octokit/octokit.js/issues/2127

What’s missing?

THere is currently no way to define types for authentication strategy options:

new Octokit({
  authStrategy: createMyAuth,
  auth: myAuthOptions
})

Why?

It would be great to get the same intellisense as for the other options

Alternatives you tried

@weswigham layed out how this is possible to do in https://github.com/octokit/rest.js/issues/13#issuecomment-582678977

We plan to implement endpoints the same way, so we can remove the endpoint types from @octokit/types, and instead move it to an optional library, or multiple libraries even, so that we can provide the correct types for each GitHub Enterprise Server version.

This is going to be a bigger project.

gr2m avatar Apr 18 '21 20:04 gr2m

``

chrissyjai avatar Jun 19 '21 23:06 chrissyjai

Ok

MelnikovAG avatar Sep 12 '21 17:09 MelnikovAG