feat: new web middleware
Resolves #623
Before the change?
- Users of platforms that don't have the
unref()function property onsetTimeoutwould get errors - No web standard middleware was exported
After the change?
- Adds a new web standards middleware
- Bumps the required version of
@octokit/webhookstov18.7.0
Pull request checklist
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
- [ ] Yes
- [x] No
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀
It seems to be working fine!
I had some issues with the private key format when trying to get it to work on Cloudflare Workers without nodejs_compat, so maybe it should be added that to the README.
https://github.com/octokit/auth-app.js#standalone-usage https://github.com/gr2m/universal-github-app-jwt#private-key-formats https://github.com/gr2m/universal-github-app-jwt/blob/715d7b5f5327e4d49afe99ff9d4aaed3d36a33b0/lib/get-token.js#L23-L27