readme.so icon indicating copy to clipboard operation
readme.so copied to clipboard

Bug: dark mode in preview ruins display of emoji and color

Open yipei1028 opened this issue 2 years ago • 2 comments

Describe the bug

To Reproduce Steps to reproduce the behavior:

  1. Go to editor
  2. Click on dark/light mode switcher
  3. See as following: Emojis display with weird filter and color code display incorrectly image

Expected behavior Emojis and color code should be consistent under both dark mode and light mode. image

Screenshots NA

Additional context NA

yipei1028 avatar Jun 19 '22 07:06 yipei1028

I looked into the implementation of mode switching. Using filter: invert(0.9) is handy but come with some drawbacks as describe above.

I would love to make a PR to do the enhancement. Let me know if that is possible! Thx.

yipei1028 avatar Jun 19 '22 07:06 yipei1028

@yipei1028 feel free to open a PR with a fix! thanks!

octokatherine avatar Jun 19 '22 17:06 octokatherine