liboping icon indicating copy to clipboard operation
liboping copied to clipboard

src/oping.c: always use "%s"-style format for printf()-style functions

Open trofi opened this issue 4 years ago • 1 comments

ncuses-6.3 added printf-style function attributes and now makes it easier to catch cases when user input is used in palce of format string when built with CFLAGS=-Werror=format-security:

oping.c:1265:41: error: format not a string literal and no format arguments [-Werror=format-security]
 1265 |                                         hist_symbols_utf8[index]);
      |                                         ^~~~~~~~~~~~~~~~~

Let's wrap all the missing places with "%s" format.

trofi avatar Nov 15 '21 08:11 trofi

This works for me.. @octo Can it be merged?

brd avatar Aug 12 '24 15:08 brd