Add list of players awaiting allow/challenge to game-actions UI

[dnathe4th]

trafficstars

Resolves #41

[octachrome]

I like this, and I am ok to merge it. But we are now tracking the allows in two separate variables, one of which is redundant. It makes me think about moving the global allows variable into the state instead, and deriving everything from that. I think the reason that allows was not originally part of the state is that it feels like private information - when you play the game in real life, everyone does not say "I allow this action" - there's a bit of uncertainty about whether another player is going to challenge (so you don't have to). @JackieNiebling - what do you think? Should whether other players have clicked "allow" be secret?

[dnathe4th]

Yeah both of those are valid points. I had not considered the secretness of allowing, since presumably the game is normally played face to face. I guess when someone challenges you don't know who else might have wanted to challenge? If I'm the only one who has felt frustration not knowing who's response was outstanding, I can keep this on my own fork or put it behind a setting.

[octachrome]

I like the option of making this a setting. Other ideas:

• Allows are anonymous for say 60 seconds, then they become visible, when it could reasonably be considered as time wasting.
• Show "waiting for 3 people to respond" instead of showing their names, until there is only one person left, then shame them with their name. This mirrors the real-life game where it becomes clear when one person is procrastinating from their body language.

[JackieNiebling]

I think having a visible 'allowed this' tied directly to a player adds an unnecessary meta-game to the game where you can (attempt) to infer what someone else is holding based on how fast they allow. In the table top version, everyone would be considering whether to challenge and this real-life pause would both include them waiting for others with more information to challenge and themselves trying to work out the odds (and ramifications) of a challenge by them.

[JackieNiebling]

So to clarify, I like the 'waiting for x players to respond'

[Trevor-Welch]

I also like the "waiting for X players" dialog as well, but I believe you could even say "players are thinking..." with a Maximum Wait timer of some sort that could be a setting.

However, I do believe there should be some sort of indicator that not everyone has made a decision and that's why the game is paused until either everyone has made an anonymous action or the X second timer is expired.

In other words, we should have the objective of a PR like "adding a waiting indicator"

[octachrome]

Show "waiting for 3 people to respond" instead of showing their names, until there is only one person left, then shame them with their name. This mirrors the real-life game where it becomes clear when one person is procrastinating from their body language.

@dnathe4th do you fancy giving this a try?