tyxml icon indicating copy to clipboard operation
tyxml copied to clipboard

Wrong error message for popular HTML code (`div` within a `label`)

Open Mbodin opened this issue 2 years ago • 2 comments

There is a popular way to style checkbox based on this HTML code:

  <label class="switch" for="checkbox">
    <input type="checkbox" id="checkbox" />
    <div class="slider"></div>
  </label>

What I did not realise is that this HTML, although popular, does not respect the specification (div should be span here).

TyXML does detect that and correctly rejects the program:

let%html checkbox =
  "<label class='switch' for='checkbox'>"
    "<input type='checkbox' id='checkbox' />"
    "<div class='slider'></div>"
  "</label>"

However, the error message is just wrong: Error: Unmatched start tag 'label', pointing at the beginning of the label element. It took me quite a long time to understand what was happening: it would be nice to have it pointing to the div element instead and state that it can't be within a label element.

I'm using TyXML 4.6.0 with tyxml-ppx.

Mbodin avatar Nov 20 '23 16:11 Mbodin

That's probably an issue in lambdasoup. @aantron ?

Drup avatar Nov 27 '23 16:11 Drup

I've opened https://github.com/aantron/markup.ml/issues/77 about this. Thanks!

I can't promise when this might be addressed, but it will happen eventually and be pulled into a release.

aantron avatar Nov 29 '23 10:11 aantron