tyxml icon indicating copy to clipboard operation
tyxml copied to clipboard

SVG: Fix the element `<animate>`

Open ilankri opened this issue 2 years ago • 3 comments

Fix https://github.com/ocsigen/tyxml/issues/305.

ilankri avatar Apr 12 '22 15:04 ilankri

Didn't see this PR before making my own fixes. Though as I now skimmed the code of this PR, I didn't see a fix for a_animation_values, a_keyTimes and a_keySplines - which all need to be semicolon separated instead of comma-separated. My working version is here: https://github.com/rand00/tyxml

rand00 avatar Jun 20 '22 20:06 rand00

oups, looks like I missed these bug reports and PRs. @rand00 Can you make a PR with the package of everything ?

Drup avatar Jun 21 '22 08:06 Drup

Yes - I'll merge the PRs together in a moment

rand00 avatar Jun 21 '22 09:06 rand00