Missing version in META file

[hhugo]

Starting with lwt 5.8.0 (lwt 5.7.0 is fine), the version is missing from lwt META's files.

The version in the META can be queried by ocamlfind. Some packages query it to check their dependencies.

Actual behavior

$ ocamlfind query lwt -format %v
[unspecified]

Expected behavior

$ ocamlfind query lwt -format %v
5.{8,9}.0

In 5.7.0, the version was present in the opam files. I suspect, but I'm not 100% confident, that dune extracts this info to generate the META.

In 5.8.0 and above, opam files are generated from dune-project but dune-project doesn't contain any version info.

In js_of_ocaml, I use dune-release to release packages and dune-release distrib create an archive with a dune-project file updated with the correct version.

[raphael-proust]

Thanks, I'll make a 5.8.1 and mark 5.8 as avoid-version in opam-repository.

[raphael-proust]

I've made https://github.com/ocaml/opam-repository/pull/27204 for https://github.com/ocsigen/lwt/tree/5.8.1

[raphael-proust]

doesn't seem to fix the ocamlfind version…

I'll investigate when I have time

[raphael-proust]

trying to add the package version information right into the dune-project file now

[raphael-proust]

works for 5.8.1

I'll mark 5.8.0 as avoid-version, and do the same for 5.9

[raphael-proust]

AFAICT this is fixed on 5.8 via 5.8.1, and nearly fixed (waiting for PR merge) for 5.9.

We could mark 5.8.0 and 5.9.0 as avoid-version, or we could mark them incompatible with js_of_ocaml. @hhugo does it make any difference to you?

[hhugo]

AFAICT this is fixed on 5.8 via 5.8.1, and nearly fixed (waiting for PR merge) for 5.9.

We could mark 5.8.0 and 5.9.0 as avoid-version, or we could mark them incompatible with js_of_ocaml. @hhugo does it make any difference to you?

There is no incompatibility with jsoo. This issue was with ojs-base before its switch to dune version (<= 0.6).