lwt icon indicating copy to clipboard operation
lwt copied to clipboard

Add Lwt_retry library

Open shonfeder opened this issue 1 year ago • 1 comments

Adds the Lwt_retry library discussed in #1028 as a separate package. I believe all guidance suggested there by @raphael-proust has been incorporated. Thanks for that!

I did not add an iter function, since I think this doesn't add any value over using Lwt_stream.iter directly.

I've tried to make the code, documentation, and tests consistent with the style I found in other locations in the code base.

shonfeder avatar Oct 15 '24 21:10 shonfeder

Thanks! I'll have a look at the dune version thing this week

raphael-proust avatar Oct 19 '24 08:10 raphael-proust

Rebased on #1035 so I could update the package author and maintainer data. I'll need to rebase on master once that is merged in.

The only CI failures remain the FreeBSD and MacOS failures that are occurring in the trunk:

Test 'getgrgid and Unix.getgrgid' in suite 'lwt_unix' raised 'Not_found'
Test 'getgrnam and Unix.getgrnam' in suite 'lwt_unix' raised 'Not_found'

shonfeder avatar Oct 28 '24 23:10 shonfeder

I'll need to rebase on master once that is merged in

you can go ahead @shonfeder

raphael-proust avatar Oct 29 '24 10:10 raphael-proust

Rebased! Should be good for a final review and/or merge! Thanks again for the reviews and guidance along the way, @raphael-proust :)

shonfeder avatar Oct 29 '24 19:10 shonfeder

Anything else you'd like to see here @raphael-proust ?

shonfeder avatar Nov 04 '24 02:11 shonfeder

Ready to merge unless the CI shows I messaed up something with my suggested+applied changes

raphael-proust avatar Nov 04 '24 07:11 raphael-proust

Thank you for the fixes!

shonfeder avatar Nov 04 '24 12:11 shonfeder

Thanks for the contribution!!

raphael-proust avatar Nov 04 '24 13:11 raphael-proust