js_of_ocaml icon indicating copy to clipboard operation
js_of_ocaml copied to clipboard

Make number representations compatible with Wasm

Open OlivierNicole opened this issue 1 year ago • 1 comments

This is best reviewed commit by commit. It adds a number of missing conversions, and other changes that have been performed in Wasm_of_ocaml in order to expose number-manipulating functions that are compatible with both the JS and Wasm backends.

This is part of a series of PRs intending to reduce the diff between js_of_ocaml and wasm_of_ocaml.

OlivierNicole avatar Jul 29 '24 09:07 OlivierNicole

Thanks. Looks good. Can you fix the CI and squash the fixup ?

hhugo avatar Aug 28 '24 21:08 hhugo

Done. It looks like the failing test will only work if I integrate the single commit from #1650, which redefines Js.number_t as being Js.number Js.t.

This may break programs that do not perform explicit float conversions yet.

OlivierNicole avatar Aug 29 '24 15:08 OlivierNicole

Done. It looks like the failing test will only work if I integrate the single commit from #1650, which redefines Js.number_t as being Js.number Js.t.

This may break programs that do not perform explicit float conversions yet.

I removed the last commit, and fixed the hypertree example to use number_t

hhugo avatar Aug 29 '24 19:08 hhugo

Thank you

OlivierNicole avatar Sep 02 '24 12:09 OlivierNicole