eliom icon indicating copy to clipboard operation
eliom copied to clipboard

Session groups: semantics change when no group is set

Open balat opened this issue 9 years ago • 6 comments

Currenlty, when no session group is set, the IP is used to group the session together, which does not make a lot of sense.

I suggest to replace that by: « If no session group is set, there is one group per session »

This happens for example when user is not logged in. Changing this would make group references work even if user is not logged in, with a reasonable semantics.

Any thoughts about that?

If we decide to change this, we can simplify the implementation of Os_tips.

balat avatar Sep 16 '16 14:09 balat

Sure, the IP doesn't make much sense, we live in a world with dynamic IPs and whole groups behind a NAT.

I will look into how to implement this. (I am not all that familiar with our low-level state code.)

vasilisp avatar Sep 19 '16 09:09 vasilisp

We have an urgent need of this. Do you think it could be implemented soon? Otherwise we will do the same kind of hack as in Os_tips.

balat avatar Mar 27 '17 15:03 balat

I can't really predict how hard it is before I try to do it. Should I, or is the hack trivial to implement?

vasilisp avatar Mar 28 '17 10:03 vasilisp

We already implemented the hack (which is quite straightforward: just use a group ref when connected and a session ref when not connected). So there is no emergency. But the problem will come again every time we use a group reference.

balat avatar Mar 29 '17 09:03 balat

Great. In that case, I will try to do it on top of the cohttp version, to prevent unnecessary divergence.

vasilisp avatar Mar 29 '17 11:03 vasilisp

Let's talk when you want to start this. I will probably remember something about the implementation ;)

balat avatar Mar 29 '17 11:03 balat