ocsf-schema icon indicating copy to clipboard operation
ocsf-schema copied to clipboard

Object/filename naming inconsistency

Open FluffySocks32 opened this issue 1 year ago • 0 comments

Hi,

During development of a python json schema parser, we noticed a few naming inconsistencies which required edge cases (Could not use the Elixir json schema generator). Below are those edge cases, I can break out to seperate issues if required or if issues are confirmed to be positive.

  • v1.0.0 - Inside the filesystem class, the name of the file is filesystem.json, yet the object name is file_activity. Based on the previous naming conventions for most of the other classes, the name of the file should be file_system and the object name be file_system_activity.

  • v1.0.0 - The above issue is also highlighted inside the network file activity class. As the name of the file is file_activity but the object name is network_file_activity. The file name should be network_file.json. Like wise to web resource access, and web resource.

  • v1.0.0 - enums for activity id are being added via an include file and directly referenced. Would it be possible to pick one method?

  • v1.0.0 - Observables are referenced solely as data types. To build out an enum for the json schema, we have to iterate over each of these data types and fine the corresponding. Would it be possible to move the observables into a enum include style format?

All issues above are just semantics and are not major at all. When building out parsers for json schemas, edge cases just need to be built which isn't the end of the world, but slightly painful. Awesome work on the schema!!

Thank you

FluffySocks32 avatar Nov 21 '23 02:11 FluffySocks32