imgui_club icon indicating copy to clipboard operation
imgui_club copied to clipboard

Memory Editor: Added extended features

Open Dimoks opened this issue 9 months ago • 5 comments

Memory Editor: Added extended selection features, scrolling, copy functionality, address input options, search panel, and UTF-8 display.

Dimoks avatar Jul 18 '25 06:07 Dimoks

Hello, Thanks for the PR. This looks generally desirable, but seems a bit large to be reviewed easy. Do you think this could be split into multiple commits, one per feature?

ocornut avatar Jul 18 '25 07:07 ocornut

Separated by features. Will this be acceptable?

Dimoks avatar Jul 19 '25 10:07 Dimoks

Seems good. Thanks! Will ease review. I'm currently away for a little bit of time but I'll catch up with this eventually.

ocornut avatar Jul 20 '25 09:07 ocornut

You seem to frequently use PushID()/PopID() for cases where a simple use of ## in the string would work better.

e.g.

            ImGui::PushID("CopyDec_Preview");
            if (ImGui::SmallButton("Copy"))
                ImGui::SetClipboardText(buf);
            ImGui::PopID();

could be:

            if (ImGui::SmallButton("Copy##CopyDec"))
                ImGui::SetClipboardText(buf);

"Memory Editor: Add copy functionality to DrawPreviewLine."

Would be better implemented with a right-click menu + tooltip with long timer. The 3 duplicate code could be in 1 function.

There are quite a few features here, I'm starting to be unsure if we should be adding all of them to this mini library. I'll investigate it more later.

ocornut avatar Aug 04 '25 07:08 ocornut

I didn't like adding the ID myself. I wasn't aware of ##. It seems inappropriate to introduce a context menu here; it's much easier to press a button next to the value than to navigate through the menu.

Dimoks avatar Aug 04 '25 11:08 Dimoks