Missed support for some keys from Japanese (JIS) Keyboard

[ssh4net]

Version/Branch of Dear ImGui:

Version 1.91.9, Branch: docking

Back-ends:

imgui_impl_vulkan.cpp + imgui_impl_glfw.cpp

Compiler, OS:

Windows 10, VS2022

Full config/build information:

Dear ImGui 1.92.0 WIP (19196)
--------------------------------
sizeof(size_t): 8, sizeof(ImDrawIdx): 2, sizeof(ImDrawVert): 20
define: __cplusplus=199711
define: _WIN32
define: _WIN64
define: _MSC_VER=1943
define: _MSVC_LANG=202002
define: IMGUI_HAS_VIEWPORT
define: IMGUI_HAS_DOCK
--------------------------------
io.BackendPlatformName: imgui_impl_glfw (3500)
io.BackendRendererName: imgui_impl_vulkan
io.ConfigFlags: 0x00000483
 NavEnableKeyboard
 NavEnableGamepad
 DockingEnable
 ViewportsEnable
io.ConfigViewportsNoDecoration
io.ConfigNavCaptureKeyboard
io.ConfigInputTextCursorBlink
io.ConfigWindowsResizeFromEdges
io.ConfigWindowsMoveFromTitleBarOnly
io.ConfigMemoryCompactTimer = 60.0
io.BackendFlags: 0x00001C0E
 HasMouseCursors
 HasSetMousePos
 PlatformHasViewports
 HasMouseHoveredViewport
 RendererHasVtxOffset
 RendererHasViewports
--------------------------------
io.Fonts: 2 fonts, Flags: 0x00000000, TexSize: 512,128
io.DisplaySize: 1800.00,1040.00
io.DisplayFramebufferScale: 1.00,1.00
--------------------------------
style.WindowPadding: 8.00,8.00
style.WindowBorderSize: 0.00
style.FramePadding: 4.00,3.00
style.FrameRounding: 0.00
style.FrameBorderSize: 0.00
style.ItemSpacing: 8.00,4.00
style.ItemInnerSpacing: 4.00,4.00

Details:

Japanese 108 keys keyboard have some additional keys that not exist in other keyboards. https://irohabiyori.com/wp-content/uploads/2021/08/IMG_2781-4-1-2048x895.jpg

As result this keys completely unrecognised or incorrectly recognized as a key press in ImGui input (including emscripten demo on MacBook).

| keycode 93 _ keycode 94 "eng" keycode 102 "kana" keycode 104 "fn" keycode 179

Interesting, but text input works correctly with symbols.

Screenshots/Video:

No response

Minimal, Complete and Verifiable Example code:

[ocornut]

Clicked on your name revealed this old unanswered issue :)

For ref you were using IMGUI_VERSION=19196 and 19198 reorganized some of this, e.g. a9e5382, which probably solved some of it. If you could update and check which are remaining?

I don't know what the keycode values you provided are (which API and if there are actually keycode or scancode), but they don't match GLFW key codes values.

Please add this at the bottom of ImGui_ImplGlfw_KeyCallback() and report all problematic values and keys, as well as OS.

    if (action == GLFW_PRESS)
        IMGUI_DEBUG_LOG("Press glfw keycode %d scancode %d -> ImGuiKey_%s\n", keycode, scancode, ImGui::GetKeyName(imgui_key));