imgui icon indicating copy to clipboard operation
imgui copied to clipboard

Is a premake5 CI wanted?

Open learn-more opened this issue 1 year ago • 3 comments

Version/Branch of Dear ImGui:

features/premake5

Back-ends:

Compiler, OS:

Full config/build information:

No response

Details:

My Issue/Question:

Are you interested in having a CI/workflow to test premake5 (in the premake5 branch?) And if so:

  • Should this be added to the same workflow build.yml that contains all builders?
  • Would it be fine to use a re-usable workflow?

Screenshots/Video:

No response

Minimal, Complete and Verifiable Example code:

No response

learn-more avatar Aug 01 '24 08:08 learn-more

If you are actually user of the premake branch, then I'd happily take a CI thing for it (which will stay in the branch for now).

Would it be fine to use a re-usable workflow?

I don't quite understand that page, but use what you think is good and simple.

ocornut avatar Nov 24 '25 16:11 ocornut

If you are actually user of the premake branch, then I'd happily take a CI thing for it (which will stay in the branch for now).

Would it be fine to use a re-usable workflow?

I don't quite understand that page, but use what you think is good and simple.

Since premake does not have a 'build' like cmake does, there needs to be platform specific build instructions in the CI.

There are three choices here:

  1. One .yml file per platform (some code duplication, but the individual files are the simplest
  2. One .yml file for everything (There will be some conditions enabling / disabling steps depending on the platform making the .yml file less simple)
  3. Multiple .yml files:
    1. One 'generic' file with most of the steps (a re-usable workflow)
    2. Multiple platform specific ones, that only contain the platform specific build commands, and leverage the generic re-usable workflow for the rest.
  4. Handle the platform specific 'build' commands from premake, like this: https://github.com/learn-more/GamepadDebug/blob/main/scripts/actions.lua and https://github.com/learn-more/GamepadDebug/blob/main/.github/workflows/msbuild.yml

For simplicity I would suggest 1 or 2.

learn-more avatar Nov 26 '25 09:11 learn-more

There’s already a big yml file for everything so it should be (2) and just add items to it. It doesn’t need to cover every possible combination just a basic sanity check.

ocornut avatar Nov 26 '25 10:11 ocornut