imgui icon indicating copy to clipboard operation
imgui copied to clipboard

Input text cursor rendering issues

Open tpecholt opened this issue 2 years ago • 6 comments

Version/Branch of Dear ImGui:

Version: 1.90 Branch: docking

Back-end/Renderer/Compiler/OS

Back-ends: imgui_impl_android.cpp + imgui_impl_opengl3.cpp Compiler: Android NDK Clang Operating System: Android

My Issue/Question:

I would like the rendering of the text cursor in input controls to be more configurable.

  1. Right now the rendering is done by drawing a 1px line. That is problematic with DPI scaling so the cursor is barely visible.

  2. The color should be configurable too currently it is fixed to ImGuiCol_Text. Android uses different color for text cursor and text.

Screenshots/Video

cursor

tpecholt avatar Nov 19 '23 14:11 tpecholt

We don't have a standardized mechanism to specify general/global scaling and would probably wait until we have one.

Similarly I don't disagree we could have a specific color for it but it likely would have to wait until we update the style system to avoid cluttering out existing list.

ocornut avatar Nov 29 '23 13:11 ocornut

Yes but the difference is for other settings like WindowPadding, ItemSpacing... I can call ImStyle::ScaleAllSizes(). And as for fonts I can load them with scaled size. So using existing functionality I am already able to achieve DPI scaling of UI elements. But the width of the text cursor is fixed so I can't scale it unless I directly modify ImGui code.

tope99 avatar Nov 29 '23 13:11 tope99

I would also like to have configurable cursor color.

tksuoran avatar Mar 19 '25 16:03 tksuoran

For scaling, I'm currently working on general scaling system and standardized scaling factor so I would like this to be part of it and not another style variable. But I could add the color sooner.

ocornut avatar Mar 19 '25 16:03 ocornut

I've added a color for the cursor. I cannot add the thickness scale yet because the way this will be exposed depends on questions I don't have the right answer just yet (but actively working on it).

ocornut avatar Mar 19 '25 16:03 ocornut

Awesome - Thank you!

tksuoran avatar Mar 19 '25 17:03 tksuoran