os_pipe.rs

os_pipe.rs copied to clipboard

enh request: Implement async read/write traits

4

e.g. AsyncRead, AsyncBufRead etc. This would require a dependency on futures, so perhaps a feature flag. Wouldn't need to bring in tokio or anything large, and as far as I...

rbtcollins

deprecation warning in nix on OSX

6

https://travis-ci.org/oconnor663/os_pipe.rs/jobs/408710890 ``` warning: use of deprecated item 'sys::nix::unistd::pipe2': pipe2(2) is not actually atomic on these platforms. Use pipe(2) and fcntl(2) instead --> src/unix.rs:17:9 | 17 | nix::unistd::pipe2(nix::fcntl::OFlag::O_CLOEXEC).map_err(nix_err_to_io_err)?; | ^^^^^^^^^^^^^^^^^^ |...

oconnor663

nonblocking pipes?

4

This would require switching to CreateNamedPipe on Windows. Which we might want to expose anyway.

oconnor663

Conversion to ChildStd{in,out,err}

4

I think it would be nice to provide a conversion into the standard library `ChildStd{in,out,err}` types. This could tie in nicely with https://github.com/tokio-rs/tokio/pull/4045 to allow converting these into non-blocking pipes...

Darksonn

Move src/bin/* to examples

2

Is there any reason to be able to do `cargo install` those binaries?

ignatenkobrain

stdin/stdout/stderr now implement AsRawFd

1

This will land in 1.21. We might want to incorporate it: https://github.com/rust-lang/rust/pull/43459

oconnor663