Jack O'Connor

whitespace escaping problems when executing paths on Windows?

1

What's the expected way to deal with this sort of thing? Can `sh` do it for you automatically? _Should_ it?!

silent no-op if you forget to call run()

2

That sucks.

Also, what's the right thing to do if there's a fatal exception while a thread is running. Join up on the way out? Calling a blocking function during exception handling...

deprecation warning in nix on OSX

6

https://travis-ci.org/oconnor663/os_pipe.rs/jobs/408710890 ``` warning: use of deprecated item 'sys::nix::unistd::pipe2': pipe2(2) is not actually atomic on these platforms. Use pipe(2) and fcntl(2) instead --> src/unix.rs:17:9 | 17 | nix::unistd::pipe2(nix::fcntl::OFlag::O_CLOEXEC).map_err(nix_err_to_io_err)?; | ^^^^^^^^^^^^^^^^^^ |...

nonblocking pipes?

4

This would require switching to CreateNamedPipe on Windows. Which we might want to expose anyway.

stdin/stdout/stderr now implement AsRawFd

1

This will land in 1.21. We might want to incorporate it: https://github.com/rust-lang/rust/pull/43459

inconsistency between Handle and ReaderHandle

2

The latter kills on drop, the former doesn't. That seems like a pretty bad inconsistency. Maybe `Handle` should kill on drop too?

What if we froze the child with SIGSTOP, then queried it's childen, then froze them with SIGSTOP, and so on recursively? Could we guarantee that nothing in the tree gets...