duct.rs icon indicating copy to clipboard operation
duct.rs copied to clipboard
verified publisher icon oconnor663

impl IntoExecutablePath for camino paths?

Open sunshowers opened this issue 4 years ago • 3 comments

Hey Jack, been a while! hope you're doing well :)

We released https://github.com/withoutboats/camino recently which adds UTF-8 path types. The readme explains the advantages of using it -- I was wondering if you think implementing IntoExecutablePath for Utf8Path and Utf8PathBuf would be reasonable (perhaps behind a feature flag).

Thanks!

sunshowers avatar Feb 25 '21 21:02 sunshowers

I only have time to write a brief comment at the moment, but I just want to say that this sounds like a good idea, and I would've been really nice to know about camino when I was writing this mess: https://github.com/BLAKE3-team/BLAKE3/blob/master/b3sum/what_does_check_do.md :)

oconnor663 avatar Feb 25 '21 22:02 oconnor663

Yikes! Yeah camino would really help for that, wouldn't it.

I can submit a PR for this. Would you prefer camino be

  • always used
  • used with a default feature
  • used with a non-default feature?

sunshowers avatar Feb 25 '21 23:02 sunshowers

Let's start with a non-default feature, if that's ok with you.

oconnor663 avatar Feb 26 '21 15:02 oconnor663