blake3-py icon indicating copy to clipboard operation
blake3-py copied to clipboard

Update maturin version to ~=1.0

Open kmichel-aiven opened this issue 1 year ago • 3 comments

This allows building blake3 with maturin 1.0, 1.1, 1.2 and future compatible versions.

The package was built and tested with each latest minor version of maturin since 0.14 (0.15.3, 1.0.1, 1.1.0 and 1.2.3) by incrementally increasing the upper bound and running :

# edit version then :
pip install --verbose --no-binary :all: . && pytest

https://www.maturin.rs/changelog

kmichel-aiven avatar Sep 05 '23 06:09 kmichel-aiven

Now that Maturin is post-1.0, maybe we should use a compatible version specifier like maturin~=1.2?

oconnor663 avatar Sep 07 '23 23:09 oconnor663

Now that Maturin is post-1.0, maybe we should use a compatible version specifier like maturin~=1.2?

Good point. I've set it to ~=1.0 instead of ~=1.2 if that's ok.

That still allows compatibility with the latest but reduces the pain on Linux distribution that still package maturin 1.0 or 1.1 (Fedora 37 to 39, Debian sid). Since the build also works with these versions, no need to block them ?

kmichel-aiven avatar Sep 08 '23 06:09 kmichel-aiven

Hi, did you have time to look at this ?

kmichel-aiven avatar Oct 03 '23 07:10 kmichel-aiven