plugin-autocomplete icon indicating copy to clipboard operation
plugin-autocomplete copied to clipboard

Add Fish autocomplete

Open p-dealwis opened this issue 4 years ago • 10 comments

My branch comprises of changes from a recently closed PR. I have made the required changes to fix the unit tests and added in a missing one.

p-dealwis avatar Jan 07 '21 20:01 p-dealwis

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Pramodya De Alwis <p***@p***.c***.nz>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

salesforce-cla[bot] avatar Jan 07 '21 20:01 salesforce-cla[bot]

Thanks for the contribution! Before we can merge this, we need @p-dealwis to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] avatar Jan 07 '21 20:01 salesforce-cla[bot]

This ticket relates to the recently closed PR #5

p-dealwis avatar Jan 07 '21 22:01 p-dealwis

Can this be merged?

lenovouser avatar Feb 27 '22 17:02 lenovouser

@p-dealwis Are you still interested in getting this merged?

If so, does the fish autocompletion work with spaces? oclif introduced support for space delineated commands since you first submitted this PR so I'd prefer for any new autocomplete logic to support both spaces and colons

mdonnalley avatar Sep 29 '22 19:09 mdonnalley

@mdonnalley I don't use fish anymore...nor do I use oclif. If anyone wants to go ahead and add autocompletion with spaces please be my guest :) Otherwise close the PR....

p-dealwis avatar Apr 05 '23 06:04 p-dealwis

Will this PR be continued ?

maastrich avatar May 07 '23 17:05 maastrich

@Maastrich as per my comment above, please feel free to carry on from where I left off

p-dealwis avatar May 24 '23 20:05 p-dealwis

Hey all 👋🏼

Sorry for the radio silence here, I don't think we can provide an ETA about adding support for fish completion (even if we can re-use @p-dealwis's work, we'll have to commit to keep it up to date and at feature parity with bash, zsh and pwsh ).

As a side project, I was thinking about start working on a 3rd party oclif plugin for shells not supported by plugin-autocomplete yet, would you be interested in something like this? (👍🏼 👎🏼 )

cristiand391 avatar May 30 '23 17:05 cristiand391

I'm currently working on something on a fork of mine, I make a PR soon, it kinds of rework a bit the project in order to be as agnostic as possible about shells that are used.

Will create a draft pull_request for review purposes ;)

It handles:

  • completion with spaces
  • completion with semi column
  • could handle more separators if needed

Thanks @cristiand391 for your time

PS: here is the PR from my fork (still need a rebase to retrieve PowerShell completion)

maastrich avatar Jun 01 '23 07:06 maastrich

fyi: I wrote a plugin to use oclif CLIs with carapace-spec, you can use it to get shell completion in a bunch of shells: https://github.com/cristiand391/oclif-carapace-spec-plugin

cristiand391 avatar Oct 16 '24 02:10 cristiand391