Add Fish autocomplete
My branch comprises of changes from a recently closed PR. I have made the required changes to fix the unit tests and added in a missing one.
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Pramodya De Alwis <p***@p***.c***.nz>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.
Thanks for the contribution! Before we can merge this, we need @p-dealwis to sign the Salesforce.com Contributor License Agreement.
This ticket relates to the recently closed PR #5
Can this be merged?
@p-dealwis Are you still interested in getting this merged?
If so, does the fish autocompletion work with spaces? oclif introduced support for space delineated commands since you first submitted this PR so I'd prefer for any new autocomplete logic to support both spaces and colons
@mdonnalley I don't use fish anymore...nor do I use oclif. If anyone wants to go ahead and add autocompletion with spaces please be my guest :) Otherwise close the PR....
Will this PR be continued ?
@Maastrich as per my comment above, please feel free to carry on from where I left off
Hey all 👋🏼
Sorry for the radio silence here, I don't think we can provide an ETA about adding support for fish completion (even if we can re-use @p-dealwis's work, we'll have to commit to keep it up to date and at feature parity with bash, zsh and pwsh ).
As a side project, I was thinking about start working on a 3rd party oclif plugin for shells not supported by plugin-autocomplete yet, would you be interested in something like this? (👍🏼 👎🏼 )
I'm currently working on something on a fork of mine, I make a PR soon, it kinds of rework a bit the project in order to be as agnostic as possible about shells that are used.
Will create a draft pull_request for review purposes ;)
It handles:
- completion with spaces
- completion with semi column
- could handle more separators if needed
Thanks @cristiand391 for your time
PS: here is the PR from my fork (still need a rebase to retrieve
PowerShellcompletion)
fyi: I wrote a plugin to use oclif CLIs with carapace-spec, you can use it to get shell completion in a bunch of shells:
https://github.com/cristiand391/oclif-carapace-spec-plugin