parser icon indicating copy to clipboard operation
parser copied to clipboard

Typed arguments

Open dhleong opened this issue 6 years ago • 2 comments

See https://github.com/oclif/oclif/issues/301

Instead of doing args as const we can do name: "name" as const to ensure the name is kept; if that's omitted then you still get a map type for the args property. Non-string arg types can be inferred from the results of parser functions or default values.

dhleong avatar Nov 30 '19 00:11 dhleong

Thanks for the contribution! Before we can merge this, we need @dhleong to sign the Salesforce.com Contributor License Agreement.

salesforce-cla[bot] avatar Nov 30 '19 00:11 salesforce-cla[bot]

Codecov Report

Merging #66 into master will decrease coverage by 91.38%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #66       +/-   ##
==========================================
- Coverage   91.38%   0.00%   -91.39%     
==========================================
  Files          11       1       -10     
  Lines         325      29      -296     
  Branches       86      14       -72     
==========================================
- Hits          297       0      -297     
- Misses         12      29       +17     
+ Partials       16       0       -16     
Impacted Files Coverage Δ
src/validate.ts 0.00% <0.00%> (-96.88%) :arrow_down:
src/util.ts
src/screen.ts
src/deps.ts
src/help.ts
src/flags.ts
src/list.ts

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00ae12f...8656a85. Read the comment docs.

codecov[bot] avatar Nov 30 '19 00:11 codecov[bot]