dev-cli icon indicating copy to clipboard operation
dev-cli copied to clipboard

'See code' links to GitHub won't work in Typescript monorepo

Open JaimeObregon opened this issue 3 years ago • 0 comments

This way of checking for a TypeScript repository in the readme command is fragile:

    if (plugin.pjson.devDependencies && plugin.pjson.devDependencies.typescript) {

In a TypeScript monorepo using workspaces, typescript can be defined at the root package's devDependencies, where plugin.pjson.devDependencies.typescript wont reach.

In my setup this is causing to silently miss all the links to see the source in GitHub, but this seems to be provoking #126 and #143 too.

JaimeObregon avatar Jan 09 '22 15:01 JaimeObregon