core icon indicating copy to clipboard operation
core copied to clipboard

Use `module: node12` in tsconfig.json; supports not transpiling `import() / dynamic import` for CommonJS code

Open typhonrt opened this issue 3 years ago • 1 comments

A most recent merged PR for Typescript now better supports Node 12. In particular there is no need for the "semi-hack" used in module-loader.ts.

You can see discussion here and the PR here. When the latest Typescript version is available w/ this PR I'll look into adding module: node12 to tsconfig.json and verify that import dynamic works correctly with the Oclif core build and remove the workaround.

A blog post about the Typescript 4.5 beta.

typhonrt avatar Sep 25 '21 00:09 typhonrt

@typhonrt Is this work that you're still interested in doing? Or can we close this?

mdonnalley avatar Jul 14 '22 15:07 mdonnalley

This issue has been linked to a new work item: W-13832724

git2gus[bot] avatar Jul 26 '23 18:07 git2gus[bot]