config icon indicating copy to clipboard operation
config copied to clipboard

Add isRunByDefault option to command.run()

Open rizzlesauce opened this issue 4 years ago • 3 comments

https://github.com/oclif/oclif/issues/277

rizzlesauce avatar Mar 14 '20 21:03 rizzlesauce

Codecov Report

Merging #100 into master will decrease coverage by 66.81%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #100       +/-   ##
=========================================
- Coverage   66.81%     0%   -66.82%     
=========================================
  Files           7      2        -5     
  Lines         452     12      -440     
  Branches      127      3      -124     
=========================================
- Hits          302      0      -302     
+ Misses        101     12       -89     
+ Partials       49      0       -49
Impacted Files Coverage Δ
src/index.ts 0% <0%> (-100%) :arrow_down:
src/debug.ts 0% <0%> (-45.46%) :arrow_down:
src/ts-node.ts
src/plugin.ts
src/util.ts

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b0c2c9e...744d0a2. Read the comment docs.

codecov[bot] avatar Mar 14 '20 21:03 codecov[bot]

I need to add more to this to get to the desired signature of: Command.run({isRunByDefault: boolean}).

EDIT: this is done

rizzlesauce avatar Mar 15 '20 02:03 rizzlesauce

Thanks for the PR on this @rizzlesauce! I really don't like to not use your efforts, but this particular solution was an edge case that was easier for me to write than explain. Thanks for your patience as well!

See my comment https://github.com/oclif/oclif/issues/277#issuecomment-668271675 on adding a root index command.

RasPhilCo avatar Aug 03 '20 23:08 RasPhilCo