Bernie Reiter
Bernie Reiter
Thank you for reviewing and approving, Adam! (Apologies for not replying any sooner -- I was AFK from Friday until yesterday!) > > how about instead introducing a has_bookmark( $bookmark_name...
One thing we need to be mindful of here is that this patch will change the code of the tag processor with regard to what we merged into Core 🤔...
Rebased on #47933 and modified to add the bookmark invalidation logic to the 6.3 compat layer version of this class.
I've added `has_bookmark()` and basic unit test coverage. (Note that we cannot yet test if the invalidation logic work since we simply don't have any method yet that would invalidate...
@dmsnell I think I've addressed all of your feedback; I've only been unable to add test coverage for `seek()` with a non-existent bookmark ([see](https://github.com/WordPress/gutenberg/pull/47559#discussion_r1106367174)). Good enough? 😬
> Pending discussion on how to proceed, what I imagine we might do is end up getting `compat/wordpress-6.3` in as a copy of what's in the long-running branch over at...
Rebased, now that https://github.com/WordPress/gutenberg/pull/47933 has landed 😊 @adamziel @dmsnell Care to give this another look (and ideally approval)? 😊 🙏
> Do we have a WordPress Trac ticket we could reference in the PR? I think it will become an official recommendation soon for PHP changes that we know require...
Thanks @dmsnell @adamziel @gziolo! It's mergin' time! 💥
I'll file a PR against `wordpress-develop` later today!