Bernie Reiter
Bernie Reiter
Hmm, looks like `inject_ignored_hooked_blocks_metadata_attributes` was previously _really_ template-specific. I'm second-guessing now if it makes sense to use it as a shared filter for both `rest_pre_insert_wp_template` (and `_part`) on the one...
> I'm starting to think that we should after all start with a distinct filter function for `rest_pre_insert_wp_navigation` (basically copying over `block_core_navigation_update_ignore_hooked_blocks_meta`), and then work backwards from there 🤔 We...
> I've experimented with this approach here #6604 > > Keen to know how you feel it compares to this one based on your comments above. Loving it! That one...
Should we close this one in favor of https://github.com/WordPress/wordpress-develop/pull/6604? 😊
I'd been largely unaware that we already have some mechanics for block variations in place on the server side. (I'd thought they were almost entirely confined to the client.) [This...
Some more notes on the `namespace/blockname/variation` alias idea (e.g. `core/social-link/wordpress`): The parser doesn't currently allow more than one slash, so we'd need to change that (see [e.g.](https://github.com/WordPress/gutenberg/pull/61678/files#diff-c5cbf000e3427102b8d9a597c30abeda95de9e7ecf7de03a42fbade2dddc19a3R90)). Moreover, we'll have...
âž• On the plus side, we already seem to be creating class names for block variations that closely match the pattern we're considering for the aliases. For example, the `wordpress`...
Finally, using these "auto-generated" aliases is motivated by YAGNI -- it doesn't preclude allowing manual setting of aliases later. To keep the API simple, I'd add an `alias` (or `blockAlias`,...
I have opened this for review, as it's going to be a prerequisite for https://github.com/WordPress/wordpress-develop/pull/7296 (to which I'll push some commits shortly that will implement the required change inside of...
> These changes make sense, it seems to be mostly shifting some code around so that `apply_glock_hooks_to_content` is used more consistently. Thank you very much for reviewing and approving! >...