ocfweb icon indicating copy to clipboard operation
ocfweb copied to clipboard

Staff hours are not automatically canceled during holidays.

Open bzh-bzh opened this issue 8 years ago • 6 comments
trafficstars

Staff hours are auto-canceled if the lab is marked as force-closed manually, but the code doesn't detect if the day is a holiday, like the holiday hour code does.

bzh-bzh avatar Nov 21 '17 07:11 bzh-bzh

I'm working on something right now that is very similar so I'll do this, but i dont know how to take ownership of this and i cant find it on rt.

vaibhavjayaraman avatar Dec 23 '17 21:12 vaibhavjayaraman

This is a GitHub issue so it might not have an RT ticket yet

kpengboy avatar Dec 23 '17 23:12 kpengboy

i finished adding this and am having the leader of 501 look at it

vaibhavjayaraman avatar Dec 24 '17 06:12 vaibhavjayaraman

It is I, the leader of 501, confirming that I have indeed taken a look at it.

abizer avatar Dec 24 '17 08:12 abizer

Can the leader of 501 confirm that the pr associated to this has been merged?

glee-b avatar Jan 30 '19 01:01 glee-b

@glee- it looks like this was the PR that was supposed to fix it but it was never merged https://github.com/ocf/ocfweb/pull/364

emmatyping avatar Jan 30 '19 04:01 emmatyping