ocfweb icon indicating copy to clipboard operation
ocfweb copied to clipboard

Pages sometimes get cut off when JS is disabled

Open abizer opened this issue 7 years ago • 9 comments

I don't remember what this is called but for longer docs the bottom part gets hidden by the ocfweb footer. This occurs on Chrome in OS X and Chromium on Linux. See example:

screen shot 2017-04-05 at 2 38 16 pm

abizer avatar Apr 05 '17 21:04 abizer

This isn't supposed to happen and doesn't happen for me. Can you provide more information about browser / OS / JS / etc? It doesn't happen to me on Chrome or Firefox on Linux.

https://www.ocf.berkeley.edu/docs/staff/procedures/vhost/

chriskuehl avatar Apr 05 '17 21:04 chriskuehl

This happens if you disable JS for berkeley.edu. See for yourself.

matthew-mcallister avatar Apr 05 '17 21:04 matthew-mcallister

yeah, Matt is right. Presumably we shouldn't need JS to use the docs, I'll see if I can find a way to fix it without requiring one to enable JS.

abizer avatar Apr 05 '17 22:04 abizer

This affects every page, not just docs. If you find a fix, that'd be great.

matthew-mcallister avatar Apr 05 '17 22:04 matthew-mcallister

yes, that's expected

chriskuehl avatar Apr 05 '17 22:04 chriskuehl

patches still welcome, but it's almost impossible to implement a sticky footer correctly in a compatible way without JS. you can probably improve this case though.

chriskuehl avatar Apr 05 '17 22:04 chriskuehl

Flexbox?

bzh-bzh avatar Nov 15 '17 01:11 bzh-bzh

that was "compatible way" comment, though maybe we're okay with it not working on really old browsers -- it's just the footer, after all (plus, flexbox has okay support now -- 88% or 97% depending on if you're okay with yucky prefixes)

chriskuehl avatar Nov 15 '17 02:11 chriskuehl

We can probably auto-generate all the prefixes too, there's some things that do that (like autoprefixer for instance), so that seems reasonable in support.

jvperrin avatar Nov 15 '17 03:11 jvperrin