ocflib icon indicating copy to clipboard operation
ocflib copied to clipboard

Privileged LDAP (again)

Open ja5087 opened this issue 6 years ago • 7 comments
trafficstars

Last time we tried to merge this (see #157) the prerequisite ucbldap.passwd was not present in ocfweb, dev-ocfweb etc.

I've rolled back all the changes I made to the tests. Once the password file has been added to the puppet configs for ocfweb and Jenkins, this PR should be good for merging.

ja5087 avatar Apr 20 '19 22:04 ja5087

I think you want to take another look at this. ocflib/account/search.py was broken by the master merge. The master merge also included the revert of the last version, so you may need to include a commit reverting that as well. (For instance, ocflib/infra/ldap.py in this PR does not contain the ldap_ucb_privileged function. git revert bec763573a74fad348e6c43254009bb79a1b472c may do what you want, but you should manually verify that.)

cg505 avatar Apr 21 '19 04:04 cg505

well this is not ideal

ja5087 avatar Apr 21 '19 06:04 ja5087

@ja5087 I added a commit. I think now you will just need to fix the tests to account for the different functions.

Sorry for all the trouble. Reverting merges in git is known to be annoying and hard to handle.

cg505 avatar Apr 22 '19 18:04 cg505

What's the current status of this?

kpengboy avatar Nov 17 '19 23:11 kpengboy

It's been stalled for a while, but I do have a better understanding of the system now and could get back on it soon

ja5087 avatar Dec 08 '19 00:12 ja5087

@ja5087 would you have time to re-base and bring this over the finish line at some point? Would love to see this landed!

emmatyping avatar Sep 22 '21 08:09 emmatyping

I can potentially finish this at some point if I still have time, but I'm unsure if password is used frequently as what I encountered mostly is that we use Kerberos ticket to auth???

axmmisaka avatar Oct 11 '22 20:10 axmmisaka