ocelot icon indicating copy to clipboard operation
ocelot copied to clipboard

Published 20 hours ago • verified publisher icon ocelot-collab

Add exact drift element and map

Open nikitakuklev opened this issue 4 years ago • 1 comments

Pull request includes exact drift element, map, and test cases. Tracking results match MADX. Also, small fix to coupler kick, such that it is not used when no energy is specified.

Weirdly, many unrelated tests fail due to numerical precision issues, i.e. r_matrix - matrix element (0, 5)\n value is "3.469446951953614e-17"\n reference value is "2.6237692574149207e-17"\n tolerance is "1e-07"\n tolerance type is "relative" in unit_tests\ebeam_test\acc_utils\acc_utils_test.py:14

I suspect this is due to platform/BLAS library differences, but please double check.

nikitakuklev avatar Sep 04 '20 17:09 nikitakuklev

Hi Nikita, thanks for the pull request. We'll look at it after the major code refactoring we're doing right now.

sergey-tomin avatar Sep 17 '20 08:09 sergey-tomin