oceandao icon indicating copy to clipboard operation
oceandao copied to clipboard

Implement test coverage for Funding Round workflows

Open idiom-bytes opened this issue 3 years ago • 3 comments

We need to implement test coverage so we can validate the Funding Round logic is working well. Test implementation should take the funding round from undefined, to started, and all the way to Voting Ends.

  • Start Funding Round
  • Update Submissions
  • Start DD
  • Start Voting
  • Update Voting
  • End Voting

idiom-bytes avatar Mar 16 '22 05:03 idiom-bytes

What would take more time to make this improvement?

  • Let's figure out how much of DAOBot we want to maintain and keep. Perhaps we should consider from DAOBot to Proposal Portal.
  • Build coverage to have the Funding Round tested & increase confidence.

We might want to approach this from a clean slate, separate environment:

  • Staging Environment - Basic Tests - More static, configured for a set of tests that need to run.
  • Staging Environment - Funding Round Tests - Clean slate so we can run a funding round from A-Z.

Sample

// We may want to have a separate process.env.AIRTABLE_BASEID = 'roundUpdateValidationTable'

// configure the table as vanilla (csv from Airtable) // configureFundingRound() // testFundingRound()

// configureUpdateSubmissions() // testUpdateSubmissions()

// configureStartDD() // testUpdateDD()

"Start Funding Round" - https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/oceandao/180 "Update Submissions" - https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/oceandao/180 "Start DD" - https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/oceandao/180 "Start Voting" - https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/oceandao/180 "Update Voting" - https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/oceandao/180 "End Voting" - https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/oceandao/180

idiom-bytes avatar Mar 16 '22 14:03 idiom-bytes

The requirements from this ticket overlap. Both 151 and 180 are working to provide coverage to the funding round. https://app.zenhub.com/workspaces/oceandao-60a669231c2ed7000e90684b/issues/oceanprotocol/daobot/151

idiom-bytes avatar Mar 29 '22 16:03 idiom-bytes

This is a complex/larger task, however there are various dependencies within the test itself. Let's continue to spend some points on this, and if it gets too big let's have a clear cut off so that we can manage the total amount of effort.

@idiom-bytes review PR and provide some recommendations

idiom-bytes avatar Mar 31 '22 14:03 idiom-bytes