ocean.py
ocean.py copied to clipboard
Addresses imported from the venv
Fixes #971 .
Changes proposed in this PR:
- removed
--pre
flag from ocean-lib installation step - fixed addresses import, updated address file path
- tested on rinkeby.
Test output:
It retrieved the addresses successfully.
This should work by default, not just if you use ExampleConfig. Putting it into ExampleConfig is too late.
Examples:
- Anyone using ocean_lib for some remote network should be able to just specify the network RPC. From that, it should auto-find the chainid. From that, it should auto-find the addresses. If the user has to specific chainid or addresses, then we're still not done.
- You can capture the essence of (1) in the test_mumbai.py::test_ocean_tx. It should work, without having to specify the Ocean addresses anywhere. (And not by forcing it in some example config).
@mariacarmina please use the latest version of main.Then, keeping your --pre
changes, I think adding the changes in get_contracts_addresses, like done for the CHAIN_ID, is a good way to go.
@trentmc, can we have some test keys on mumbai as we have exposed for ganache? In order to make test_mumbai::test_ocean_tx
pass, we need to have remote test keys exported and I thought that maybe we can set them in pytest.ini
file as well.
@trentmc, can we have some test keys on mumbai as we have exposed for ganache? In order to make
test_mumbai::test_ocean_tx
pass, we need to have remote test keys exported and I thought that maybe we can set them inpytest.ini
file as well.
We have test keys, but they cannot be publicly visible because bots will eat the fake MATIC, and you can only get a little fake MATIC at a time from faucets.
Our test keys are visible to CI as Github Actions Secrets. The CI can see them: the other Mumbai test needs fake MATIC and the tests pass.
You will need the keys locally too. Instructions are at sections 3 of: https://github.com/oceanprotocol/ocean.py/blob/main/READMEs/developers.md