ocean.py icon indicating copy to clipboard operation
ocean.py copied to clipboard

CI tests randomly fail: many tests saying "Exception: Address not found for ganache. Please check your address file."

Open trentmc opened this issue 2 years ago • 1 comments

Pre-requisite to this issue: #938 "Streamline Config: no config.ini file, no dict, just envvars." Then, doing this issue will be much, much simpler.


Describe the bug

CI randomly fails across all tests that need ganache.

Here's an example fail from this PR (for remote C2D). Summary from the example: all_fails.txt, example_error.txt.

Here's another fail, this time from a direct commit to main - tweaking a README.

Importantly, they don't always fail, it seems to be randomly. Here's an example pass from a direct commit to main, from the commit from another README tweak done around same time as the tweak above.

To Reproduce

Any push will trigger CI (from main, or a branch/PR). Things may fail, or not.

Notes

This is recent. Just started happening after the commit for #923, to start having remote tests. That was introduced in this commit: https://github.com/oceanprotocol/ocean.py/commit/a4fb91153891e2b68be90d4a5a7558bbb44e14d4

But we've been seeing other random failures of CI, e.g. #905. Though, that one may be more due to random timeout of C2D, as Calina mentions in the issue.

This issue is perhaps another symptom of a super-messy Config setup. #938 proposes streamlining Config.

However maybe in the near term there's a quick fix for this issue.

That said, it's almost certainly better to simply do #938 ASAP. It will remove a lot of pain for us in developing on ocean.py.

trentmc avatar Sep 19 '22 20:09 trentmc

I ran into this issue recently, even after #938 was merged. https://github.com/oceanprotocol/ocean.py/actions/runs/3108890497/jobs/5038572779

MantisClone avatar Sep 23 '22 14:09 MantisClone

Resolved in #975

mariacarmina avatar Oct 05 '22 11:10 mariacarmina

I recently ran into this issue again: https://github.com/oceanprotocol/ocean.py/actions/runs/3222427637/jobs/5271487336

MantisClone avatar Oct 11 '22 12:10 MantisClone